Skip task add hooks for forwarded sync-matched tasks#10016
Open
Skip task add hooks for forwarded sync-matched tasks#10016
Conversation
When a task is forwarded from a child partition to the parent for sync matching, processTaskAddHooks was called on both partitions. The child fires hooks when its forwarder successfully delivers the task, and the parent fires hooks again when TrySyncMatch succeeds. This causes double-counting for any hook-based metrics or tracking. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rkannan82
changed the title
rkannan82
changed the title
rkannan82
changed the title
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Skip
processTaskAddHookson the parent partition when a forwarded task is sync-matched.The async path is not affected — forwarded tasks that fail to sync-match return
errRemoteSyncMatchFailedbefore reaching the hooks call, so the child partition handles both spooling and hook invocation.Why
When a child partition forwards a task to the parent for sync matching, hooks fire on both partitions — the child fires hooks when the forwarder successfully delivers the task (
priTaskMatcher.Offerreturnstrue), and the parent fires hooks again whenTrySyncMatchsucceeds. This causes double-counting for any hook-based metrics or tracking.How did you test it?
Unit tests across all three partition manager suites (Classic, Pri, Fair):