Add chasm Archetype tag to dlq metric writer#10004
Open
awln-temporal wants to merge 4 commits intomainfrom
Open
Add chasm Archetype tag to dlq metric writer#10004awln-temporal wants to merge 4 commits intomainfrom
awln-temporal wants to merge 4 commits intomainfrom
Conversation
awln-temporal
force-pushed
the
awln-dlq-archetype-tag
branch
from
c2580f4 to
1b5ae3e
Compare
awln-temporal
force-pushed
the
awln-dlq-archetype-tag
branch
from
1b5ae3e to
14230d4
Compare
yycptt
approved these changes
Apr 22, 2026
Comment on lines
127
to
128
| metrics.TaskCategoryTag(task.GetCategory().Name()), | ||
| metrics.NamespaceStateTag(namespaceState), |
Member
There was a problem hiding this comment.
I think we can remove those two in next release after this change is rolledout and alert definition get updated. TaskTypeTag gives both the queue and the active/standby information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add chasm Archetype tag to dlq metrics.
Why?
Need a way to filter CHASM tasks by Archetype, through use of indexed labels in Loki. Instead of filtering queries like
{k8s_component="history"} |~ "ChasmPure" |~ "Scheduler" |~ "error|fail" | json, we can filter using{k8s_component="history",archetype="Scheduler"}for better performance.How did you test it?