Conversation
Sushisource
approved these changes
Apr 28, 2026
THardy98
force-pushed
the
feat/bump-core
branch
from
434d0fa to
218e13e
Compare
Sushisource
reviewed
Apr 28, 2026
Comment on lines
+637
to
+639
| // DNS load balancing is mutually exclusive with HTTP CONNECT proxy in sdk-core. | ||
| // Disable it when a proxy is configured; otherwise use the default. | ||
| .dns_load_balancing(if http_connect_proxy.is_some() { |
Member
There was a problem hiding this comment.
Ugh, that was stupid of me wasn't it. Ofc this constitutes a breaking change because it defaults to on for any existing users using the connect proxy. 🤦♂️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
DWISOTT
Why?
includes envconfig fix