Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ jobs:
TEMPORAL_CLOUD_MTLS_TEST_CLIENT_KEY: ${{ secrets.TEMPORAL_CLIENT_KEY }}

# For Temporal Cloud + API key tests
TEMPORAL_CLOUD_API_KEY_TEST_TARGET_HOST: us-west-2.aws.api.temporal.io:7233
TEMPORAL_CLOUD_API_KEY_TEST_TARGET_HOST: us-east-1.aws.api.temporal.io:7233
TEMPORAL_CLOUD_API_KEY_TEST_NAMESPACE: ${{ vars.TEMPORAL_CLIENT_NAMESPACE }}
TEMPORAL_CLOUD_API_KEY_TEST_API_KEY: ${{ secrets.TEMPORAL_CLIENT_CLOUD_API_KEY }}

Expand Down
3 changes: 2 additions & 1 deletion .gitmodules
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
[submodule "sdk-core"]
path = packages/core-bridge/sdk-core
url = https://github.com/temporalio/sdk-core.git
url = https://github.com/temporalio/sdk-rust.git
branch = main
6 changes: 3 additions & 3 deletions packages/proto/protos/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@
*
* ### Core SDK API
*
* [Core SDK](https://github.com/temporalio/sdk-core) interfaces can be accessed in the `coresdk` namespace.
* [Core SDK](https://github.com/temporalio/sdk-rust) interfaces can be accessed in the `coresdk` namespace.
*
* ```ts
* import { coresdk } from '@temporalio/proto';
* const activityTask: coresdk.activity_task.IActivityTask = { ... };
* ```
*
* The source protos are in the [sdk-core repo](https://github.com/temporalio/sdk-core/tree/ts-release/protos/local/temporal/sdk/core), for example [`ActivityTask` in `activity_task.proto`](https://github.com/temporalio/sdk-core/blob/85454935e39f789aaaa81f8a05773f8e2cdbcde2/protos/local/temporal/sdk/core/activity_task/activity_task.proto#L12).
* The source protos are in the [sdk-rust repo](https://github.com/temporalio/sdk-rust/tree/ts-release/protos/local/temporal/sdk/core), for example [`ActivityTask` in `activity_task.proto`](https://github.com/temporalio/sdk-rust/blob/85454935e39f789aaaa81f8a05773f8e2cdbcde2/protos/local/temporal/sdk/core/activity_task/activity_task.proto#L12).
*
* ### Temporal Service API
*
Expand All @@ -23,7 +23,7 @@
* const retryPolicy: temporal.api.common.v1.IRetryPolicy = { ... };
* ```
*
* The source protos are in [sdk-core/protos/api_upstream/temporal/api/](https://github.com/temporalio/sdk-core/tree/ts-release/protos/api_upstream/temporal/api), for example [`RetryPolicy` in `temporal/api/common/v1/message.proto`](https://github.com/temporalio/sdk-core/blob/85454935e39f789aaaa81f8a05773f8e2cdbcde2/protos/api_upstream/temporal/api/common/v1/message.proto#L96).
* The source protos are in [sdk-rust/protos/api_upstream/temporal/api/](https://github.com/temporalio/sdk-rust/tree/ts-release/protos/api_upstream/temporal/api), for example [`RetryPolicy` in `temporal/api/common/v1/message.proto`](https://github.com/temporalio/sdk-rust/blob/85454935e39f789aaaa81f8a05773f8e2cdbcde2/protos/api_upstream/temporal/api/common/v1/message.proto#L96).
*
* The gRPC service methods are documented in the proto comments and in the corresponding [`Temporal CLI` docs](https://docs.temporal.io/cli/).
* @module
Expand Down
2 changes: 1 addition & 1 deletion packages/test/src/run-activation-perf-tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ if (!wf.inWorkflowContext()) {
async function activate(workflow: VMWorkflow, activation: coresdk.workflow_activation.IWorkflowActivation) {
// Core guarantees the following jobs ordering:
// initWf -> patches -> update random seed -> signals+update -> others -> Resolve LA
// reference: github.com/temporalio/sdk-core/blob/a8150d5c7c3fc1bfd5a941fd315abff1556cd9dc/core/src/worker/workflow/mod.rs#L1363-L1378
// reference: github.com/temporalio/sdk-rust/blob/a8150d5c7c3fc1bfd5a941fd315abff1556cd9dc/core/src/worker/workflow/mod.rs#L1363-L1378
// Tests are likely to fail if we artifically make an activation that does not follow that order
const jobs: coresdk.workflow_activation.IWorkflowActivationJob[] = activation.jobs ?? [];
function getPriority(job: coresdk.workflow_activation.IWorkflowActivationJob) {
Expand Down
2 changes: 1 addition & 1 deletion packages/test/src/test-workflows.ts
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ async function activate(t: ExecutionContext<Context>, activation: coresdk.workfl

// Core guarantees the following jobs ordering:
// initWf -> patches -> update random seed -> signals+update -> others -> Resolve LA
// reference: github.com/temporalio/sdk-core/blob/a8150d5c7c3fc1bfd5a941fd315abff1556cd9dc/core/src/worker/workflow/mod.rs#L1363-L1378
// reference: github.com/temporalio/sdk-rust/blob/a8150d5c7c3fc1bfd5a941fd315abff1556cd9dc/core/src/worker/workflow/mod.rs#L1363-L1378
// Tests are likely to fail if we artifically make an activation that does not follow that order
const jobs: coresdk.workflow_activation.IWorkflowActivationJob[] = activation.jobs ?? [];
function getPriority(job: coresdk.workflow_activation.IWorkflowActivationJob) {
Expand Down
2 changes: 1 addition & 1 deletion packages/test/src/workflows/core-issue-589.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { unblockSignal } from './definitions';

const { customLogger } = wf.proxySinks<CustomLoggerSinks>();

// Demo for https://github.com/temporalio/sdk-core/issues/589
// Demo for https://github.com/temporalio/sdk-rust/issues/589
export async function coreIssue589(): Promise<void> {
wf.setHandler(wf.defineQuery('q'), () => {
return 'not important';
Expand Down
Loading