Conversation
|
|
|
|
dnr
reviewed
Apr 20, 2026
chaptersix
reviewed
Apr 22, 2026
dnr
reviewed
Apr 22, 2026
Comment on lines
+63
to
+69
| // minFairnessWeight matches server-side limit in temporal/service/matching/fairness_util.go | ||
| // Server clamps weights to this minimum when applying them | ||
| minFairnessWeight = 0.001 | ||
|
|
||
| // maxFairnessWeight is the maximum weight value allowed | ||
| // Server clamps weights above this value down to this maximum | ||
| maxFairnessWeight = 1000.0 |
Contributor
There was a problem hiding this comment.
we should not enforce these at all. clients do not need to know the effective range that the server is currently configured with, only that the the weight must be positive.
Contributor
Author
There was a problem hiding this comment.
Sure, I've removed these enforcements. Do you feel the same way about the fairness key limit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Add support for setting fairness key weight overrides.
Why?
We should expose this feature to users.
Checklist
How was this tested:
Newly added tests and tested against a local dev server
Any docs updates needed?
Yes; https://docs.temporal.io/cli/task-queue