Be more consistent with git clone environment#4918
Open
LecrisUT wants to merge 2 commits into
Open
Conversation
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request centralizes the GIT_ASKPASS environment variable configuration within the git_clone utility, removing redundant setup logic from its callers. Feedback suggests retaining the environment parameter in git_clone to maintain API flexibility for custom variables. Additionally, the reviewer recommends including GIT_TERMINAL_PROMPT=0 for consistency and utilizing the update() method for more efficient environment initialization.
LecrisUT
added
the
ci | full test
1 task
LecrisUT
added
the
area | maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks weird that we use the
GIT_ASKPASSonly in some places and not other, let's be consistent