Make color and other logging method params keyword-only#4912
Open
happz wants to merge 2 commits into
Open
Conversation
It is very easy to log a message plus color name because when value is omitted, color name becomes the `value` argument. Prevent any doubt by making color & everything but the message - or key & value - keyword-only arguments.
happz
added
the
code | no functional change
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request converts logging method parameters, such as color, shift, and level, into keyword-only arguments across the codebase and updates all call sites. Update the warn method in tmt/log.py to make shift and stacklevel keyword-only with default values to ensure consistency with the warning method and other utility changes.
LecrisUT
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is very easy to log a message plus color name because when value is omitted, color name becomes the
valueargument. Prevent any doubt by making color & everything but the message - or key & value - keyword-only arguments.Pull Request Checklist