Skip to content

Let finish step run before report #4906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
happz wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

Let finish step run before report #4906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e77fd8e
Let `finish` step run before `report`
happz May 20, 2026
d856a30
squash: fix test
happz May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/plan/show/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ rlJournalStart
rlRun "grep -Pzo '(?sm)^ *prepare ?$.*^ *report' $rlRun_LOG > $output"
rlAssertGrep " how shell" $output
rlAssertGrep " script systemctl start libvirtd" $output
rlRun "grep -Pzo '(?sm)^ *report ?$.*^ *finish' $rlRun_LOG > $output"
rlRun "grep -Pzo '(?sm)^ *report ?$.*' $rlRun_LOG > $output"
rlAssertGrep " how html" $output
rlAssertGrep " open true" $output
rlRun "grep -A30 '^ *finish' $rlRun_LOG > $output"
Expand Down
2 changes: 1 addition & 1 deletion tmt/steps/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
TRY_PHASE_ORDER_PREPARE_FEATURE_FIPS = PHASE_ORDER_PREPARE_INSTALL_RECOMMENDS + 10

# Supported steps and actions
StepName = Literal['discover', 'provision', 'prepare', 'execute', 'report', 'finish', 'cleanup']
StepName = Literal['discover', 'provision', 'prepare', 'execute', 'finish', 'report', 'cleanup']
STEPS: list[StepName] = list(typing.get_args(StepName))
ActionName = Literal['login', 'reboot']
ACTIONS: list[ActionName] = list(typing.get_args(ActionName))
Expand Down
Loading