Omit .git directory in guest.pull() during prepare.distgit#4898
Omit .git directory in guest.pull() during prepare.distgit#4898lukaszachy wants to merge 1 commit into
.git directory in guest.pull() during prepare.distgit#4898Conversation
There was a problem hiding this comment.
Code Review
This pull request modifies tmt/steps/prepare/distgit.py to exclude the .git directory during source retrieval to avoid rsync errors. Feedback suggests appending to the exclude list rather than overwriting it to preserve default patterns.
|
Seems some copr outage |
|
/packit build |
Don't forget to mention it on our "Annoying issues" canvas, please. |
6aebda4 to
f2b1309
Compare
Found by 'pcs': rpmbuild uses git to apply patches, and newer git run maintenance automatically. tmt was running into race condition where some git objects were deleted after rsync from `guest.pull` was already aware of them, which lead to broken prepare with ```sync warning: some files vanished before they could be transferred (code 24)``` We don't need the .git directory anyway so we will save few bits in the download as well. Fixes: #4893
f2b1309 to
3164cfc
Compare
|
I am not sure about this one. The original issue is more of a misunderstanding of the scope of |
.git directory in guest.pull() during prepare.distgit
Found by 'pcs': rpmbuild uses git to apply patches, and newer git run maintenance automatically. tmt was running into race condition where some git objects were deleted after rsync from
guest.pullwas already aware of them, which lead to broken prepare withsync warning: some files vanished before they could be transferred (code 24)We don't need the .git directory anyway so we will save few bits in the
download as well.
Fixes: #4893
Pull Request Checklist