Filter noisy oneOf schema warnings during tmt lint#4896
Open
tcornell-bus wants to merge 1 commit into
Open
Conversation
When validating steps that use oneOf schemas (e.g., report plugins), the linter was showing validation errors from all alternative schemas rather than just the one matching the 'how' value. This created confusing noise like warnings about missing polarion fields when using reportportal. Now when a oneOf validation fails, only errors from the schema matching the specified 'how' value are shown. Updated tests to verify that irrelevant schema warnings are filtered out while relevant ones are still displayed. Assisted-by: Cursor AI
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the linter to filter schema validation sub-errors based on the 'how' plugin value, reducing noise in the output. Test cases were also updated to ensure that only relevant warnings are reported. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When validating steps that use
oneOfschemas (e.g., report plugins), the linter was showing validation errors from all alternative schemas rather than just the one matching the 'how' value. This created confusing noise like warnings about missing polarion fields when using reportportal.Now, when a
oneOfvalidation fails, only errors from the schema matching the specified 'how' value are shown.Updated tests to verify that irrelevant schema warnings are filtered out while relevant ones are still displayed.
Assisted-by: Cursor AI
Fixes: #4680
Pull Request Checklist