Fix SVG curve parameter extraction once more#864
Open
ferdiusa wants to merge 1 commit intotecnickcom:mainfrom
Open
Fix SVG curve parameter extraction once more#864ferdiusa wants to merge 1 commit intotecnickcom:mainfrom
ferdiusa wants to merge 1 commit intotecnickcom:mainfrom
Conversation
The switch from `preg_match_all` to `preg_split` in PR tecnickcom#855 broke parsing of "optimized" svg paths. In these, the "-" can be used as delimiter between numbers as well.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The switch from
preg_match_alltopreg_splitin PR #855 broke parsing of "optimized" svg paths. In these, the "-" can be used as delimiter between numbers as well.See Issue #767 for report by @tmhf.
The regular expression suggested in this PR reverts back to token based behaviour while keeping the fix for "e" exponents from the original issue.