Skip to content

chore: test ci env #35173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kailixu wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

chore: test ci env #35173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/common/src/tglobal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ static int32_t taosAddClientCfg(SConfig *pCfg) {
tstrncpy(defaultFqdn, "localhost", TSDB_FQDN_LEN);
}
if (cost >= 1000) {
printf("warning: get fqdn cost %" PRId64 " ms\n", cost);
printf("warning: get fqdn cost %" PRId64 " (ms)\n", cost);
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In this codebase, it is preferred to use the internal logging macros (such as uWarn, uError, or uInfo) instead of printf for consistency and to ensure that messages are correctly handled by the logging system. These macros automatically include appropriate log level prefixes and handle trailing newlines. Additionally, units like ms are typically not enclosed in parentheses in log messages within this project.

    uWarn("get fqdn cost %" PRId64 " ms", cost);

Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning string prints as e.g. cost 123 (ms), which is an unusual unit format and less readable than the previous 123 ms. Consider formatting as ... cost <n> ms (or ... cost <n>ms) to match common log/unit conventions and avoid looking like a missing value in parentheses.

Suggested change
printf("warning: get fqdn cost %" PRId64 " (ms)\n", cost);
printf("warning: get fqdn cost %" PRId64 " ms\n", cost);

Copilot uses AI. Check for mistakes.
}

TAOS_CHECK_RETURN(
Expand Down
Loading