publish: the registry PR step survives main moving mid-publish - #168
Merged
Merged
Conversation
The render step dirties tpkg-registry.yaml in-tree; the PR step then branches from origin/main. A mirror PR landing on main while the matrix builds (e.g. the mri upsert during v0.16.24) aborts the checkout — the in-tree render differs from both HEADs — and every --failed rerun hits the same wall deterministically. Save to temp, discard the dirty tree, branch, restore: the temp copy is the payload either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.16.24 publish's audit+registry job failed deterministically: #166 merged mid-publish, moving
tpkg-registry.yamlon main; the job's in-tree render then abortedgit checkout -b … origin/main(Your local changes … would be overwritten), and--failedreruns re-hit the same wall.Fix: save the render to
$RUNNER_TEMP(already done),git checkout -- tpkg-registry.yamlbefore branching, restore after. The temp copy is the payload either way.The v0.16.24 registry entries were completed by hand as #167 (rendered from post-#166 main, so the mri upsert rides along).