ci: terminal 'all legs green' aggregate — the branch-protection gate - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a terminal
verifyjob — check nameall legs green— tobuild-payload.yml. It needs every job in the workflow (thebuildflavor × triplet matrix and the tag-only
releaseaudit + registryjob), runs under
always() && !cancelled(), and fails with a named::error::when:branch/PR run skips it legitimately; signing rides in-leg per spec 13
§2a, so there is no separate publish/sign job to gate).
Why
The fleet is enabling auto-merge, but without required status checks an
armed auto-merge merges instantly while matrix legs are still running
(the sibling python factory already hit this). The build legs are a
dynamic matrix — their check names shift with the flavor/triplet
vocabulary — so branch protection cannot pin any leg's name. It pins
this job's one stable name instead (the python factory's equivalent:
tamatebako/tebako-runtime-python#19).
always() && !cancelled()matters: without it a failed upstream jobwould skip this one, and a skipped required check reads as satisfied —
the gate must report red, never vanish.
After merge
Enable branch protection on
mainrequiring the checkall legs green(and lint's stableparse + ruby -c + bash -n + rspec), thenarm auto-merge.