Repository navigation
feat(macos): replace popover with native-style borderless menu panel - #48
Merged
Merged
Conversation
Ports the menu UI work from #39 without the accompanying CI workflow changes, so the app-side changes can land independently. - Replace the NSPopover-based menu with a borderless panel that matches the look and behaviour of a native menu bar menu. - Add MenuBackdrop for the panel's vibrancy/blur backing. - Show a single constant menu bar logo instead of tinting the template image per service phase, which made the icon appear to change shade during every launch. - Document the liquid-glass adoption plan under macos/docs. Excluded from #39: .github/workflows/ci.yml and .github/workflows/release.yml.
ssddOnTop
added
the
test-release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same changes as #39, excluding all CI changes.
Included
macos/Sources/ForgeMenuBar/MenuRenderer.swift— replace the NSPopover-based menu with a borderless, native-style menu panelmacos/Sources/ForgeMenuBar/MenuBackdrop.swift(new) — vibrancy/blur backing for the panelmacos/Sources/ForgeMenuBar/AppDelegate.swift— show a single constant menu bar logo instead of tinting the template image per service phase (the icon appeared to change shade on every launch)macos/README.mdmacos/docs/liquid-glass-adoption.md(new)Excluded (CI)
.github/workflows/ci.yml.github/workflows/release.ymlRebased onto current
main(#39 was based on an older commit); the diff applied cleanly with no conflicts.Note: I could not build locally — this machine's Xcode/Swift toolchain is currently broken (
libxcodebuildLoader.dylibsymbol error), unrelated to this change. Relying on CI for the build.