Skip to content

arithmetic: support modern and legacy dependency modes #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebfull merged 4 commits into from
Jun 2, 2026
Merged

arithmetic: support modern and legacy dependency modes #747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2abb316
arithmetic: support modern and legacy dependency modes
ebfull Jun 1, 2026
44c2fd4
supply-chain: cleanups of deps / audits
ebfull Jun 1, 2026
e1b3c8f
Update modern ff and group dependencies
ebfull Jun 1, 2026
085cbf1
bump rand to 0.10.1 in lockfile
ebfull Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
cache-suffix: bench

- name: Build benchmarks
run: cargo bench --workspace --all-features --locked --bench arithmetic --bench circuits --bench pcd --bench primitives --no-run
run: cargo bench --workspace --locked --bench arithmetic --bench circuits --bench pcd --bench primitives --no-run

# Push-to-main: full run + save baseline for future comparisons
# Manual dispatch: full run + regression summary against a chosen baseline
Expand Down Expand Up @@ -109,7 +109,7 @@ jobs:
find target/gungraun -name 'summary.json' -delete

- name: Run benchmarks
run: cargo bench --workspace --all-features --locked --bench arithmetic --bench circuits --bench pcd --bench primitives -- --save-summary=json
run: cargo bench --workspace --locked --bench arithmetic --bench circuits --bench pcd --bench primitives -- --save-summary=json

- name: Summarize benchmark regressions
if: github.event_name == 'workflow_dispatch'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/debug.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ jobs:
- name: Setup Rust
uses: ./.github/actions/rust-setup
- name: Run debug tests
run: cargo test --all --locked --all-features --verbose
run: cargo test --all --locked --verbose
30 changes: 24 additions & 6 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,25 @@ jobs:
with:
components: clippy
- name: Run clippy
run: cargo clippy --workspace --lib --tests --benches --locked --all-features -- -D warnings
run: cargo clippy --workspace --lib --tests --benches --locked -- -D warnings

legacy-check:
name: legacy dependency check
needs: changes
if: needs.changes.outputs.rust == 'true' || github.event_name == 'push'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
with:
persist-credentials: false
- name: Setup Rust
uses: ./.github/actions/rust-setup
with:
cache-suffix: legacy-deps
- name: Check runtime crates with legacy dependencies
run: cargo check -p ragu_arithmetic -p ragu_pasta -p ragu_core -p ragu_primitives -p ragu_circuits -p ragu_pcd --lib --locked --no-default-features --features "alloc legacy-deps"
- name: Check root crate with legacy dependencies
run: cargo check -p ragu --lib --locked --no-default-features --features legacy-deps
Comment on lines +85 to +101

@TalDerei TalDerei Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the legacy feature flag is a temporary shim, but there's a CI gap here where it basically only does cargo check --lib and doesn't run test coverage.


proptests-fast:
name: proptests (fast)
Expand All @@ -96,7 +114,7 @@ jobs:
with:
cache-suffix: proptests-fast
- name: Run fast proptests
run: cargo test --release -p ragu_arithmetic -p ragu_core --locked --all-features proptest
run: cargo test --release -p ragu_arithmetic -p ragu_core --locked proptest
env:
PROPTEST_CASES: "64"

Expand All @@ -118,7 +136,7 @@ jobs:
with:
cache-suffix: release
- name: Run tests
run: cargo test --release --all --locked --all-features
run: cargo test --release --all --locked

test-32-bit:
name: test (i686-unknown-linux-gnu)
Expand All @@ -136,7 +154,7 @@ jobs:
apt-packages: gcc-multilib
cache-suffix: release
- name: Run 32-bit tests
run: cargo test --release --all --locked --all-features --target i686-unknown-linux-gnu
run: cargo test --release --all --locked --target i686-unknown-linux-gnu

bitrot:
name: bitrot check
Expand All @@ -150,9 +168,9 @@ jobs:
- name: Setup Rust
uses: ./.github/actions/rust-setup
with:
cache-suffix: all-features
cache-suffix: default-features
- name: Build benchmarks and examples
run: cargo build --benches --examples --all-features
run: cargo build --benches --examples

fuzz-check:
name: fuzz harness check (nightly)
Expand Down
Loading
Loading