fix(render): keep content flush after a filter rerender - #4933
Draft
lukecotter wants to merge 2 commits into
Draft
fix(render): keep content flush after a filter rerender#4933lukecotter wants to merge 2 commits into
lukecotter wants to merge 2 commits into
Conversation
The rerenderRows anchor-scan fallback used `this.rows.length - 1`, but `this.rows` is the method (arity 0), so the expression was always -1. When the scan found no anchor row (stale or out-of-range rendered window), the renderer filled from position -1 and left vDomTop negative. Use the last display-row index instead.
rerenderRows scanned the pre-filter vDomTop..vDomBottom window for an anchor row, then filled against the post-filter rows. When that window pointed past the new (smaller) row count, the stale topOffset inflated vDomTopPad into a blank strip across the top. Fall back to a fresh fill (which resets vDomTopPad) when the pre-filter window is invalid or no anchor was found. Also derive vDomBottomPad in the position branch of _virtualRenderFill from the current row count (mirroring the full-fill branch) instead of the cached vDomScrollHeight, which goes stale when the row count shrinks and leaves an inflated blank strip below the last row; refresh vDomScrollHeight too. Adds a Playwright regression test filtering 2000 rows down to ~50 and asserting no top/bottom blank strip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After a filter rerender the rendered window could leave a blank strip at the top or the
bottom of the viewport, because the window was not re-flushed against the new row set.
Fix
Keep content flush after a filter rerender.
Depends on
The
this.rows()fallback-index fix, which is included here as the first commit. Mergethat PR first; this one then reduces to a single commit.
Test
test/e2e/rerender-filter.spec.tsasserts no top or bottom blank strip.Performance
Neutral. 500k rows, K=5, medians: