fix(render): use correct fallback row index in rerenderRows - #4932
Draft
lukecotter wants to merge 1 commit into
Draft
fix(render): use correct fallback row index in rerenderRows#4932lukecotter wants to merge 1 commit into
lukecotter wants to merge 1 commit into
Conversation
The rerenderRows anchor-scan fallback used `this.rows.length - 1`, but `this.rows` is the method (arity 0), so the expression was always -1. When the scan found no anchor row (stale or out-of-range rendered window), the renderer filled from position -1 and left vDomTop negative. Use the last display-row index instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
rerenderRowsfalls back to the last row index whentopRow === false, but writesthis.rows.length - 1.this.rowsis a zero-arity method, so.lengthis 0 andthe expression is always
-1.Fix
Use
this.rows().length - 1— the last display-row index.Performance
Neutral. 500k rows, K=5, medians (measured together with the follow-up filter-window
fix, see the dependent PR):