Skip to content

perf(frozencolumns): reinitialize rows in O(n) #4909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukecotter wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf(frozencolumns): reinitialize rows in O(n) #4909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/js/modules/FrozenColumns/FrozenColumns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,8 @@ export default class FrozenColumns extends Module{

reinitializeRows(){
var visibleRows = this.table.rowManager.getVisibleRows(true);
var otherRows = this.table.rowManager.getRows().filter(row => !visibleRows.includes(row));
var visibleRowSet = new Set(visibleRows);
var otherRows = this.table.rowManager.getRows().filter(row => !visibleRowSet.has(row));

otherRows.forEach((row) =>{
row.deinitialize();
Expand Down
35 changes: 35 additions & 0 deletions test/unit/modules/FrozenColumns.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,41 @@ describe('FrozenColumns', function(){
expect(result).toContain(rightCol2);
});

test('reinitializeRows deinitializes only non-visible rows and lays out visible ones', function(){
const frozenColumns = new FrozenColumns({});

const visible = [
{ type: "row", deinitialize: jest.fn() },
{ type: "row", deinitialize: jest.fn() },
];
const hidden = [
{ type: "row", deinitialize: jest.fn() },
{ type: "row", deinitialize: jest.fn() },
];
const allRows = [visible[0], hidden[0], visible[1], hidden[1]];

frozenColumns.table = {
rowManager: {
getVisibleRows: () => visible,
getRows: () => allRows,
},
};
frozenColumns.layoutRow = jest.fn();

frozenColumns.reinitializeRows();

// only the non-visible rows are deinitialized (Set-based exclusion)
expect(hidden[0].deinitialize).toHaveBeenCalledTimes(1);
expect(hidden[1].deinitialize).toHaveBeenCalledTimes(1);
expect(visible[0].deinitialize).not.toHaveBeenCalled();
expect(visible[1].deinitialize).not.toHaveBeenCalled();

// visible rows are laid out
expect(frozenColumns.layoutRow).toHaveBeenCalledTimes(2);
expect(frozenColumns.layoutRow).toHaveBeenCalledWith(visible[0]);
expect(frozenColumns.layoutRow).toHaveBeenCalledWith(visible[1]);
});

test('_calcSpace calculates width of columns', function(){
// Create a mock table
const mockTable = {};
Expand Down
Loading