feat(desktop): propose/classify field identity — a2td W2c lockstep twin#537
Merged
Merged
Conversation
Byte-sync of lockstep classify.ts from a2td claude/w2c-propose-identity (8181dd5): LlmProposeInput.fields gains optional datasource/column_ref, emitted only when the summary has >1 datasource or duplicate display names; single-ds payloads byte-identical. Manifest regenerated via check-lockstep --update; both repos' manifests now carry identical hash 87193686 for the classify twin (CLS-003 procedure). INERT until plumbed on this side (same pattern as the #511 semanticRole landing): tmcp's propose-instruction/prewarm surfaces don't yet emit the qualified identities; that plumbing rides the #535 fields-tool coordination per the port-debt ledger. Validation firsthand: full suite 4,346 green (298 files), tsc clean, check-lockstep 6/6. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coordinated lockstep twin of a2td
claude/w2c-propose-identity(the Fix-A remainder of the multi-datasource spec — a2td PR to follow once its base merges). Per the CLS-003 twin procedure:src/desktop/binder/classify.tsbyte-synced from the a2td canonical, manifest regenerated withcheck-lockstep --update; both repos' manifests carry the identical87193686…hash.Behavior:
LlmProposeInput.fieldsentries gain optionaldatasource/column_ref, populated ONLY when the workbook summary has >1 datasource or duplicate display names — single-datasource payloads stay byte-identical. Deliberately INERT on this side until the propose-instruction/prewarm surfaces plumb the qualified identities (same landing pattern as #511's semanticRole); that plumbing is coordinated with the #535 fields-tool thread rather than a parallel port — see the port-debt ledger.Validation (orchestrator, firsthand): full suite 4,346 green (298 files),
tsc --noEmitclean,check-lockstep6/6. No tool-describe changes — combined-lean surface untouched (45,843/46,000 stands).🤖 Generated with Claude Code