Skip to content

@W-22586294: Include missing scopes in token validation error message #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephendeoca wants to merge 2 commits into
base: main
Choose a base branch
from
Open

@W-22586294: Include missing scopes in token validation error message #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8241375
add missing scopes to error description
stephendeoca Jun 4, 2026
8ebb3ec
update patch version
stephendeoca Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@tableau/mcp-server",
"description": "Helping agents see and understand data.",
"version": "2.6.3",
"version": "2.6.4",
"repository": {
"type": "git",
"url": "git+https://github.com/tableau/tableau-mcp.git"
Expand Down
7 changes: 4 additions & 3 deletions src/server/oauth/authMiddleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,8 @@ export function authMiddleware(accessTokenValidator: AccessTokenValidator): Requ
...(shouldCheckApiScopes ? requiredApiScopes : []),
];
const scopeParam = `scope="${formatScopes(requiredScopesForChallenge)}"`;
const wwwAuthenticate = `Bearer realm="MCP", error="insufficient_scope", error_description="Missing required scopes", resource_metadata="${resourceMetadataUrl}", ${scopeParam}`;
const errorDescription = `Missing required scopes: ${formatScopes(missingScopes)}`;
const wwwAuthenticate = `Bearer realm="MCP", error="insufficient_scope", error_description="${errorDescription}", resource_metadata="${resourceMetadataUrl}", ${scopeParam}`;

if (req.method === 'GET' && req.headers.accept?.includes('text/event-stream')) {
res.writeHead(403, {
Expand All @@ -141,15 +142,15 @@ export function authMiddleware(accessTokenValidator: AccessTokenValidator): Requ
});
res.write('event: error\n');
res.write(
'data: {"error": "insufficient_scope", "error_description": "Missing required scopes"}\n\n',
`data: ${JSON.stringify({ error: 'insufficient_scope', error_description: errorDescription })}\n\n`,
Comment thread
stephendeoca marked this conversation as resolved.
);
res.end();
return;
}

res.status(403).header('WWW-Authenticate', wwwAuthenticate).json({
error: 'insufficient_scope',
error_description: 'Missing required scopes',
error_description: errorDescription,
});
return;
}
Expand Down
Loading