Skip to content

Make Gig production-ready and remove the CLI REPL - #6

Merged
t04dJ14n9 merged 17 commits into
mainfrom
codex/remove-cli-repl
Jul 11, 2026
Merged

t04dJ14n9 merged 17 commits into
mainfrom
codex/remove-cli-repl

Conversation

@t04dJ14n9

Copy link
Copy Markdown
Owner

Summary

  • isolate interpreter type-resolution and panic/recover state across concurrent interpreted goroutines
  • prevent child goroutines from inheriting parent panic ancestry
  • make interpreter-owned blocking channel send, receive, and select honor RunWithContext cancellation
  • align the CLI module with Gig v1.7.7
  • completely remove the CLI REPL, plugin manager, platform plugin loaders, liner, and transitive terminal dependencies
  • expand CI across Go 1.23–1.26, both Go modules, pinned lint, and enforced root/CLI security scans
  • skip deprecated go/parser object resolution on every production parse while retaining go/types semantic resolution
  • remove the study_ast experiment and refresh English/Chinese CLI and architecture documentation

Root cause

The Go 1.25 Actions timeout was caused by per-goroutine interpreter state being stored on shared objects. Concurrent type resolution could return a bogus interface placeholder, and concurrent panic/recover could target another goroutine's frame. A final review also found that direct goroutine calls inherited their spawning frame, allowing a child recover to consume a parent panic. Separately, blocking reflected channel operations did not observe the execution context.

User impact

Gig no longer hangs indefinitely on interpreter-owned channel operations after cancellation, concurrent interpreted goroutines retain isolated panic/type state, and the CLI exposes only init, gen, and dump. Running gig repl now follows the normal unknown-command path.

Verification

  • root and CLI tests with the race detector on the current toolchain
  • root and CLI race tests with Go 1.23.1
  • deterministic red/green regression for cross-goroutine recover isolation
  • parser policy regression proving deprecated AST object fields remain unset
  • GolangCI-Lint v2.4.0 for root and CLI
  • Gosec v2.27.1 for root and CLI: 0 issues
  • Govulncheck for root and CLI: 0 reachable vulnerabilities
  • Actionlint, module verification/tidiness, and Linux/Windows cross-builds
  • benchmark suite: pass
  • eleven focused fuzz campaigns: pass
  • independent final code review: ready to merge

@t04dJ14n9
t04dJ14n9 marked this pull request as ready for review July 11, 2026 03:41
@t04dJ14n9
t04dJ14n9 merged commit 257402a into main Jul 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant