Conversation
|
One more thing to do here: if the |
|
Is this ready? |
|
No, the "rescind the notification on deletion" is not implemented. But I suppose an issue could be raised for that. Would you mind testing it as well? My use case is quite narrow and it works there, but I'm sure there are other cases that may have issues. |
|
Thanks for the info! Sure, I plan to test this GTK4 port in upcoming weeks (after next week's vacation). |
It compiles and runs fine, however it does look like it still uses GTK3 (and it still requires the gtk+-3.0 dependency). Also, it should be rebased against the latest code from main for the AppStream/desktop fixes. By the way, "Snapshots" are still listed in the unit types drop-down box (and there is also a "Take Snapshot" button). Are you sure snapshots are still supported by systemd? |
|
One more thing. This is what appears in my app list: 
I think that the "systemd GNOME ask password agent" desktop entry should probably stay hidden. |
|
I've not used |
|
Wait... I am not sure whether I understand. I thought that this whole PR was about porting systemadm to GTK4 and improving this whole (systemd-ui) project. I thought that Do you have any examples what Anyway, I still think that displaying its desktop entry is incorrect. It should probably have something like |
|
It is used for this: https://systemd.io/PASSWORD_AGENTS/ It's the reason I picked up maintenance of the project. I have
It needed no other changes to compile. |
When run as a service, it is useful to log to the journal as well.
It's already the default.
There's not much here that is interesting.
Meson guarantees this already.
And use it.
Also convert both metainfo and desktop file names to rDNS format
Update the links
The "man" option is defined as a meson feature option. Feature options possess tristate values, but using the .allowed() method casts it to a dual-valued option. Effectively, both "auto" and "enabled" were treated as boolean true, and disabled was treated as boolean false. find_program was informed that it should always check for the manpage generator, but with a boolean `required:` kwarg, it is nonfatal if not found. That meant configuring with "man=disabled", the manpage would be automatically built if the generator program was available, and with "man=auto" the project would fatally error when configuring but the generator program was not available. This is clearly confusing/wrong, so pass the option value directly instead. The default value of the option was formerly effectively set to "auto". Change its value to truly be that, so that the default behavior is preserved.
New in systemd 257
This is needed to use `GIO.Notification`, the replacement for `Gtk.StatusIcon`.
This separates the watching for things to send notifications from the handling of actual requests.
|
Ah, the GTK4 bit is not yet done. This is just to make GTK3 not have deprecation warnings. GTK4 will come later. |
I've probably done enough surgery to warrant it at this point.
3 participants
GTK4 port. Also now supports the system and user password request directories.