Skip to content

fix: public payments polish part 1#544

Merged
ovitrif merged 4 commits intomasterfrom
codex/fix-public-payments-polish-part1
May 8, 2026
Merged

fix: public payments polish part 1#544
ovitrif merged 4 commits intomasterfrom
codex/fix-public-payments-polish-part1

Conversation

@ben-kaufman
Copy link
Copy Markdown
Contributor

@ben-kaufman ben-kaufman commented May 6, 2026

Summary

  • route manually entered Pubky keys through the contact flow
  • route contact Pubky keys from Send scan, Send paste, QR scan, and QR paste flows instead of treating them as payment payloads
  • preserve and filter contact activity correctly for RBF/replaced sent transactions
  • pop the add-contact screen before opening the send sheet from contact payment routes
  • fix the new-profile first-channel LN contact payment issue where iOS published a public BOLT11 before the receiver channel was actually usable, causing route not found until receiver restart
  • publish public Paykit BOLT11 endpoints only after Lightning channels are usable/routable, and refresh/reconnect on channel-ready
  • add focused coverage for Pubky routing helpers and RBF contact propagation

Verification

  • swiftformat on touched Swift files
  • git diff --check
  • git diff --check origin/master...HEAD
  • xcodebuild build was previously attempted with writable DerivedData/SPM paths, but SwiftPM dependency resolution hung while fetching bitkit-core and was stopped

Includes the non-UI route-not-found fix from #539 and the reviewed Pubky contact scan/paste flows. Missing/disabled UI and UI polishing follow-ups are intentionally excluded.

@ben-kaufman ben-kaufman marked this pull request as ready for review May 6, 2026 15:11
@ben-kaufman ben-kaufman requested review from ovitrif and piotr-iohk May 6, 2026 15:11
@claude

This comment has been minimized.

@ben-kaufman ben-kaufman marked this pull request as draft May 6, 2026 15:19
@claude

This comment has been minimized.

@ben-kaufman ben-kaufman marked this pull request as ready for review May 6, 2026 16:08
piotr-iohk
piotr-iohk previously approved these changes May 6, 2026
Copy link
Copy Markdown
Collaborator

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@ovitrif ovitrif added this to the 2.3.0 milestone May 7, 2026
Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code, LGTM.

Tested:

  • send > scan contact QR ❌
  • send > paste contact pubky ❌
  • send > enter manually > paste contact pubky ✅
  • QR > Scan ✅
  • QR > Paste ❌

@piotr-iohk
Copy link
Copy Markdown
Collaborator

Re-tested on device. All routes work as expected now.

send > scan contact QR ✅
send > paste contact pubky ✅
send > enter manually > paste contact pubky ✅
QR > Scan ✅
QR > Paste ✅

Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@piotr-iohk
Copy link
Copy Markdown
Collaborator

Looks like the commits in this PR are not GPG/SSH signed, and branch protection requires signed commits before merge. Could you re-sign the commits @ben-kaufman?

@ben-kaufman ben-kaufman force-pushed the codex/fix-public-payments-polish-part1 branch from 4dd56fa to c67f220 Compare May 8, 2026 14:18
@ben-kaufman
Copy link
Copy Markdown
Contributor Author

@piotr-iohk updated

@ovitrif ovitrif merged commit ee78a43 into master May 8, 2026
10 checks passed
@ovitrif ovitrif deleted the codex/fix-public-payments-polish-part1 branch May 8, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants