Skip to content

PHP7 Compatibility release #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexnantel88 wants to merge 12 commits into
base: integration
Choose a base branch
from
Open

PHP7 Compatibility release #16

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5354714
PHP7 Compatibility release
May 23, 2017
5dc4bfc
Release version up to Symphony 3.x.x
Aug 23, 2017
a962e23
Release to 2.x.x max
Aug 23, 2017
41a2291
Release version for Symphony 2.x.x
Aug 23, 2017
9401adc
Documentation Fixes (#15)
twiro Aug 22, 2017
5635c19
SQL and PHP cases
Aug 24, 2017
60744be
Relase infos .. Again
Aug 25, 2017
b75cadd
Code refactoring for Database
May 30, 2018
02ae0a6
Code refactoring for EQFA
May 30, 2018
e06f916
Add forgotten "return" for uninstall method
May 31, 2018
684eef9
Remote SQL collate and charset definitions.
Dec 18, 2018
cc471cf
Apply patch from @beaubbe.
Dec 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions extension.meta.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
</author>
</authors>
<releases>
<release version="1.7.2" date="2017-05-19" min="2.5.x" max="4.x.x" php-min="5.6.x" php-max="7.x.x">
Copy link
Copy Markdown
Member

@jensscherbl jensscherbl Aug 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max should be "2.x.x", as "3.x.x" and "4.x.x" are allowed to introduce breaking changes.

Copy link
Copy Markdown
Member

@jensscherbl jensscherbl Aug 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you get php-min and php-max from? As far as I can tell, it's not part of the schema, or at least it’s not documented? http://symphonyextensions.com/schemas/extension/1.0/#changelogs-and-compatibility

Copy link
Copy Markdown
Member

@nitriques nitriques Aug 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why the PR is not merged ;) It's a change @alexnantel88 added in her 4.0 experiment. But it is soooo nice, that I'd like to add it for real. I'll check with her if she can redo the PR, but without any of the "experimental" stuff. Thanks for the review tho ;)

Copy link
Copy Markdown
Member

@jensscherbl jensscherbl Aug 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just wasn’t sure if it was an undocumented new feature in 2.7 already.

Copy link
Copy Markdown
Member

@nitriques nitriques Aug 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No no, I would not do that (voluntarily :P )

Copy link
Copy Markdown
Member

@michael-e michael-e Aug 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, I thought that php-min and php-max was a new "de-facto standard". I vaguely remember that we had a discussion about it, but unfortunately I don't remember where and when.

Copy link
Copy Markdown
Member

@nitriques nitriques Aug 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-e we agreed on this yes, but it was never implemented in an "official" way ;) I am still all for it !

Copy link
Copy Markdown
Member

@michael-e michael-e Aug 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am glad that you remember this — I was afraid that I only dreamed. :-)

Hmm, I already adopted it, e.g. here: michael-e/email_newsletter_manager@c396584

What should I do? Remove it? Or simply keep it?

Copy link
Copy Markdown
Member

@nitriques nitriques Aug 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not create a problem (for the computer) to keep it. But if you want to be strict, it should not be there.

Copy link
Copy Markdown
Member

@michael-e michael-e Aug 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-(

Copy link
Copy Markdown
Author

@alexnantel88 alexnantel88 Aug 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jensscherbl @nitriques
I've created a new branch (2.x) with the right release informations and removed the Symphony 4.x additions.

- PHP7 Compatibility
</release>
<release version="1.7.1" date="2016-01-05" min="2.5" max="2.6.x">
- Set 'entry_id' as unique
</release>
Expand Down