Skip to content

[stimulus-bundle] CSRF: support input outside the form #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DavidPetrasek wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[stimulus-bundle] CSRF: support input outside the form #1531

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
955260c
[FIX] support input outside the form
DavidPetrasek Apr 15, 2026
3599f34
new line
DavidPetrasek Apr 15, 2026
d6fb56e
fix
DavidPetrasek Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions symfony/stimulus-bundle/2.24/assets/controllers/csrf_protection_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ document.addEventListener('turbo:submit-end', function (event) {
});

export function generateCsrfToken (formElement) {
const csrfField = formElement.querySelector('input[data-controller="csrf-protection"], input[name="_csrf_token"]');
const csrfField = getCsrfField(formElement);

if (!csrfField) {
return;
Expand All @@ -46,7 +46,7 @@ export function generateCsrfToken (formElement) {

export function generateCsrfHeaders (formElement) {
const headers = {};
const csrfField = formElement.querySelector('input[data-controller="csrf-protection"], input[name="_csrf_token"]');
const csrfField = getCsrfField(formElement);

if (!csrfField) {
return headers;
Expand All @@ -62,7 +62,7 @@ export function generateCsrfHeaders (formElement) {
}

export function removeCsrfToken (formElement) {
const csrfField = formElement.querySelector('input[data-controller="csrf-protection"], input[name="_csrf_token"]');
const csrfField = getCsrfField(formElement);

if (!csrfField) {
return;
Expand All @@ -77,5 +77,17 @@ export function removeCsrfToken (formElement) {
}
}

function getCsrfField (formElement)
{
// Input element is placed inside the form
const qSel = 'input[data-controller="csrf-protection"], input[name="_csrf_token"]';
const csrfField = formElement.querySelector(qSel);
if (csrfField) {return csrfField;}

// Input element is placed outside the form
return Array.from(document.querySelectorAll(qSel))
.find((field) => field.form === formElement) || null;
}

/* stimulusFetch: 'lazy' */
export default 'csrf-protection-controller';
Loading