Skip to content

Added tracker for main contributor to footer - #748

Open
mjh316 wants to merge 11 commits into
symbol:mainfrom
mjh316:main
Open

Added tracker for main contributor to footer#748
mjh316 wants to merge 11 commits into
symbol:mainfrom
mjh316:main

Conversation

@mjh316

@mjh316 mjh316 commented Dec 31, 2021

Copy link
Copy Markdown

Modified gitstamp.py and footer.html as mentioned in #746 to keep track of the main contributor for each page on the footer.

@netlify

netlify Bot commented Dec 31, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for nemtech ready!
Built without sensitive environment variables

🔨 Explore the source changes: 0bd56bf

🔍 Inspect the deploy log: https://app.netlify.com/sites/nemtech/deploys/61cf5e7dd877d100095a7a95

😎 Browse the preview: https://deploy-preview-748--nemtech.netlify.app

@segfaultxavi segfaultxavi linked an issue Dec 31, 2021 that may be closed by this pull request
2 tasks
@segfaultxavi
segfaultxavi self-requested a review December 31, 2021 10:23

@segfaultxavi segfaultxavi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU very much for submitting this!

However, can you fix this problem? The Netlify preview is failing because of this:

5:19:14 AM: Extension error (gitstamp):
5:19:14 AM: Handler <function page_context_handler at 0x7f31ce49f3a0> for event 'html-page-context' threw an exception (exception: not enough values to unpack (expected 2, got 1))

@mjh316

mjh316 commented Dec 31, 2021

Copy link
Copy Markdown
Author

I've modified the code to handle the case where git.shortlog returns an empty string, but this always happens. Is there any specific configuration that's different for the netlify build vs local besides GITHUB_TOKEN being provided that would be related?

@mjh316

mjh316 commented Jan 2, 2022

Copy link
Copy Markdown
Author

Error seems to occur due to lack of .git folder in deployment. Will have to try another method besides using the global g git.Repo object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show "Main contributor" besides "Last contributor" on every page

2 participants