[6.2] Sema: Fix a regression in retroactive conformance diagnostic suppression#85159
Merged
Conversation
…ion. Module qualifying a protocol name in an inheritance clause should suppress retroactive conformance diagnostics for the protocol and any protocols it inherits from, just like adding the `@retroactive` attribute. Fixes a regression in Swift 6.2 introduced by swiftlang#81576. Resolves rdar://162295268 and swiftlang#85153.
Contributor
Author
|
@swift-ci please test |
tshortli
enabled auto-merge
October 27, 2025 19:02
slavapestov
approved these changes
Oct 27, 2025
nkcsgexi
approved these changes
Oct 27, 2025
tshortli
deleted the
suppress-inherited-retroactive-conformance-diags-with-module-qualification-6.2
branch
October 28, 2025 03:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@retroactiveto that clause. The effect of module qualification on inherited conformances regressed in Swift 6.2.0 due to the changes in Sema: Don't diagnose implied conformance of imported type to Sendable #81576.