Update lifetime dependence syntax and inference#72506
Merged
Merged
Conversation
meg-gupta
force-pushed
the
changesyntax
branch
2 times, most recently
from
March 22, 2024 07:11
42632b4 to
22b68c7
Compare
meg-gupta
changed the title
Contributor
Author
|
@swift-ci test |
meg-gupta
marked this pull request as ready for review
March 22, 2024 16:23
meg-gupta
requested review from
CodaFi,
DougGregor,
ahoppen,
bnbarham,
hamishknight,
hborla,
rintaro,
slavapestov,
tshortli and
xedin
as code owners
March 22, 2024 16:23
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
Swift-syntax work is pending |
atrick
approved these changes
Mar 23, 2024
atrick
left a comment
atrick
left a comment
Contributor
There was a problem hiding this comment.
Wow, this is a lot of nice work in one day! I don't see anything that needs to be changed in this PR.
Contributor
Author
|
@swift-ci test |
meg-gupta
enabled auto-merge
March 23, 2024 05:20
… pitch Pitch - swiftlang/swift-evolution#2305 Changes highlights: dependsOn(paramName) and dependsOn(scoped argName) syntax dependsOn(paramName) -> copy lifetime dependence for all parameters/self except when we have Escapable parameters/self, we assign scope lifetime dependence. Allow lifetime dependence on parameters without ownership modifier. Always infer copy lifetime dependence except when we have Escapable parameters/self, we infer scope lifetime dependence. Allow lifetime dependence inference on parameters without ownership modifier.
Contributor
Author
|
Please test with following pull request: @swift-ci Please test |
Contributor
Author
|
Please test with following pull request: @swift-ci Please test macOS platform |
1 similar comment
Contributor
Author
|
Please test with following pull request: @swift-ci Please test macOS platform |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pitch - swiftlang/swift-evolution#2305
Changes highlights:
dependsOn(paramName) and dependsOn(scoped paramName) syntax
dependsOn(paramName) -> copy lifetime dependence for all parameters/self except when we have Escapable parameters/self, we assign scope lifetime dependence.
Allow lifetime dependence on parameters without ownership modifier.
Always infer copy lifetime dependence except when we have
Escapable parameters/self, we infer scope lifetime dependence.
Allow lifetime dependence inference on parameters without ownership modifier.