Skip to content

[WebAssembly] Fix a few tests for WASI#29871

Merged
swift-ci merged 1 commit into
swiftlang:masterfrom
swiftwasm:swiftwasm-stdlib-tests
Feb 18, 2020
Merged

[WebAssembly] Fix a few tests for WASI#29871
swift-ci merged 1 commit into
swiftlang:masterfrom
swiftwasm:swiftwasm-stdlib-tests

Conversation

@MaxDesiatov

Copy link
Copy Markdown
Contributor

Disables/enables stdlib testing code appropriately when targeting WebAssembly/WASI.

This is a part of SR-9307 and #24684.

(cc @kateinoigakukun)

@gribozavr

Copy link
Copy Markdown
Contributor

@swift-ci Please test and merge

@MaxDesiatov MaxDesiatov removed the request for review from drodriguez February 17, 2020 15:15
@compnerd

Copy link
Copy Markdown
Member

I really would prefer that you didn't do this change. WASI uses musl, not glibc, and there are user visible differences between the implementations. This is going to cause problems.

@MaxDesiatov

Copy link
Copy Markdown
Contributor Author

@compnerd I can close the PR for now, but has anyone tried to support musl in the Swift infrastructure yet? Would a better approach be to support musl on say Linux directly before attempting to support it for the WASI target?

@kateinoigakukun

Copy link
Copy Markdown
Member

@compnerd Do you mean we should replace these import statements with import Musl to match library name and actual library content?

@MaxDesiatov

Copy link
Copy Markdown
Contributor Author

@kateinoigakukun Yes, that's would work best in my opinion too. Would be easiest to set this up for Linux first I think, I'm trying to build everything on Alpine to verify this.

@MaxDesiatov

MaxDesiatov commented Feb 18, 2020

Copy link
Copy Markdown
Contributor Author

@compnerd this one will be either reverted or superseded with import Musl change that I'm actively working on right now. Sorry, wasn't sure if CI was actually stuck and whether it was going to merge it at all.

@MaxDesiatov MaxDesiatov deleted the swiftwasm-stdlib-tests branch February 18, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants