Combine a parameterized test case's argument IDs into a single hashed ID#1799
Open
suzannaratcliff wants to merge 1 commit into
Open
Combine a parameterized test case's argument IDs into a single hashed ID#1799suzannaratcliff wants to merge 1 commit into
suzannaratcliff wants to merge 1 commit into
Conversation
suzannaratcliff
requested review from
briancroom,
grynspan,
harlanhaskins,
jerryjrchen and
stmontgomery
as code owners
July 16, 2026 22:13
suzannaratcliff
commented
Jul 16, 2026
| /// together, so that argument boundaries are preserved. | ||
| init(combining argumentIDs: some Sequence<Test.Case.Argument.ID>) { | ||
| var bytes = [UInt8]() | ||
| for argumentID in argumentIDs { |
Contributor
Author
There was a problem hiding this comment.
If this list is only length 1 should I skip the hashing?
grynspan
reviewed
Jul 16, 2026
| init(combining argumentIDs: some Sequence<Test.Case.Argument.ID>) { | ||
| var bytes = [UInt8]() | ||
| for argumentID in argumentIDs { | ||
| var count = UInt64(argumentID.bytes.count).littleEndian |
Contributor
There was a problem hiding this comment.
Do we need this ID to be stable across architectures? It may be sufficient to just encode the Int.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combine a parameterized test case's argument IDs into a single hashed ID
Motivation:
Test.Case.ID.argumentIDspreviously stored oneArgument.IDper argument, in order. This meant the ID grew with the number of parameters. I want to simplify this to a single combined ID that identifies the whole combination of arguments.Checklist: