Add C settings to the package manifest.#1798
Open
grynspan wants to merge 1 commit into
Open
Conversation
This PR adds C settings to the package manifest. This is necessary because when
Swift processes a C header, it does so _as C_ rather than as C++, and our C++
settings don't get applied.
I've also factored out setting the Swift, C, and C++ settings for all targets to
a separate `.map {}` call so that we don't have to remember which target types
have which factory function arguments and don't accidentally omit settings from
new targets in the future.
grynspan
requested review from
briancroom,
jerryjrchen and
stmontgomery
as code owners
July 16, 2026 15:22
| // it can only enable Library Evolution itself on those platforms. | ||
| swiftSettings += .enableLibraryEvolution(.whenApple()) | ||
| } else { | ||
| swiftSettings += .enableLibraryEvolution() |
Contributor
There was a problem hiding this comment.
The targets swift-testing-harness and SymbolShowcase don't currently have or need Library Evolution enabled, but they aren't test targets so I think under this logic they would get that enabled needlessly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds C settings to the package manifest. This is necessary because when Swift processes a C header, it does so as C rather than as C++, and our C++ settings don't get applied.
I've also factored out setting the Swift, C, and C++ settings for all targets to a separate
.map {}call so that we don't have to remember which target types have which factory function arguments and don't accidentally omit settings from new targets in the future.CMake is not impacted.
Checklist: