Remove unnecessary type casting#1736
Draft
compnerd wants to merge 3 commits into
Draft
Conversation
Contributor
|
Well… clearly not. 😄 Keep in mind we intend for our main branch to compile against the previous release (which is still 6.3 for now). |
The compiler now imports these as their canonical type, allowing us to directly use without the explicit type cast.
Member
Author
|
Clearly it does! You just didn't cherry-pick all the necessary bundled changes :) We will likely have to split this into two changes - force the types to the correct shapes where we were incorrect, and then we can do the clean up on the explicit types later. |
Contributor
|
Oh I figured there were upstream changes we'd need. But we won't be able to accept this PR while we still need to build for 6.3. |
Member
Author
|
Ah, that is unfortunate. But, understandable, we can live with this until we can adopt (hopefully) the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler now imports these as their canonical type, allowing us to directly use without the explicit type cast.