Pass original declarations to peer and extension macro expansions#3376
Open
somiljain2006 wants to merge 1 commit into
Open
Pass original declarations to peer and extension macro expansions#3376somiljain2006 wants to merge 1 commit into
somiljain2006 wants to merge 1 commit into
Conversation
somiljain2006
requested review from
ahoppen,
hamishknight,
hborla and
rintaro
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3151
Discover peer and extension macro attributes on the declaration after member-attribute expansion, but invoke the macro expansion using the original declaration. This matches the compiler's behavior and avoids passing rewritten declarations to attached macro implementations. Add regression tests covering member-attribute interactions with peer and extension macros.