Skip to content

[windows][lldb] reduce Docker image size #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahmishal merged 1 commit into from
Jun 9, 2026
Merged

[windows][lldb] reduce Docker image size #566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions swift-ci/main/windows/lldb/1809/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ RUN [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tl
RUN Set-ItemProperty -Path HKLM:\\SYSTEM\\CurrentControlSet\\Control\\FileSystem -Name LongPathsEnabled -Value 1
RUN Set-ItemProperty -Path HKLM:\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\AppModelUnlock -Name AllowDevelopmentWithoutDevLicense -Value 1 -Type DWord

# Visual Studio 2022 Community with C++ and Windows SDK components
RUN Invoke-WebRequest -Uri https://aka.ms/vs/17/release/vs_community.exe -OutFile vs_community.exe; \
Start-Process -FilePath .\\vs_community.exe -Wait -ArgumentList \
# Visual Studio 2022 Build Tools with C++ and Windows SDK components
RUN Invoke-WebRequest -Uri https://aka.ms/vs/17/release/vs_buildtools.exe -OutFile vs_buildtools.exe; \
Start-Process -FilePath .\\vs_buildtools.exe -Wait -ArgumentList \
'--quiet --wait --norestart \
--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64 \
--add Microsoft.VisualStudio.Component.VC.Tools.ARM64 \
Expand All @@ -23,7 +23,7 @@ RUN Invoke-WebRequest -Uri https://aka.ms/vs/17/release/vs_community.exe -OutFil
--add Microsoft.VisualStudio.Component.Windows11SDK.22621 \
--add Microsoft.VisualStudio.Component.VC.CMake.Project \
--add Microsoft.NetCore.Component.Runtime.9.0'; \
Remove-Item -Force vs_community.exe
Remove-Item -Force vs_buildtools.exe

# Git
RUN Invoke-WebRequest -Uri https://github.com/git-for-windows/git/releases/download/v2.47.1.windows.1/Git-2.47.1-64-bit.exe -OutFile git.exe; \
Expand Down Expand Up @@ -60,14 +60,15 @@ RUN git config --global core.symlink true; \
git config --global core.autocrlf false

# vcpkg + libxml2
RUN git clone https://github.com/microsoft/vcpkg C:\\vcpkg; \
RUN git clone --depth 1 https://github.com/microsoft/vcpkg C:\\vcpkg; \
C:\\vcpkg\\bootstrap-vcpkg.bat -disableMetrics
SHELL ["cmd", "/S", "/C"]
RUN ""C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvars64.bat" && C:\vcpkg\vcpkg install libxml2:x64-windows"
RUN ""C:\Program Files\Microsoft Visual Studio\2022\BuildTools\VC\Auxiliary\Build\vcvars64.bat" && C:\vcpkg\vcpkg install libxml2:x64-windows"

@compnerd compnerd Jun 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this at all? We build libxml2 from source for the toolchain, we should just do that here and avoid vcpkg entire.

@charles-zablit charles-zablit Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could yes. I'm not able to test this at desk, so I wanted to minimize the changes to avoid any breakage.

SHELL ["powershell", "-ExecutionPolicy", "Bypass", "-Command"]
RUN Remove-Item -Recurse -Force C:\\vcpkg\\buildtrees, C:\\vcpkg\\packages, C:\\vcpkg\\downloads
RUN [Environment]::SetEnvironmentVariable('VCPKG_ROOT', 'C:\\vcpkg', [EnvironmentVariableTarget]::Machine); \
[Environment]::SetEnvironmentVariable('PATH', $env:PATH + ';C:\\vcpkg\\installed\\x64-windows\\bin', [EnvironmentVariableTarget]::Machine)

# Add VC runtime redist DLLs to PATH
RUN $redist = (Get-ChildItem 'C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Redist\MSVC\*\x64\Microsoft.VC143.CRT' | Select-Object -First 1).FullName; \
RUN $redist = (Get-ChildItem 'C:\Program Files\Microsoft Visual Studio\2022\BuildTools\VC\Redist\MSVC\*\x64\Microsoft.VC143.CRT' | Select-Object -First 1).FullName; \
[Environment]::SetEnvironmentVariable('PATH', $env:PATH + ';' + $redist, [EnvironmentVariableTarget]::Machine)
Loading