Added non-deprecated registerHooks entrypoints - #1072
Merged
LongYinan (Brooooooklyn) merged 1 commit intoAug 14, 2026
Merged
Conversation
|
|
Contributor
Author
There was a problem hiding this comment.
Heads up: The majority of this code is just taken from esm.mts.
Patrick Shaw (PatrickShaw)
force-pushed
the
patrickshaw/registerHooks
branch
from
August 14, 2026 05:04
8996db1 to
d2e7a7b
Compare
Contributor
Author
|
I've considered just doing a straight copy+paste of Just let me know if this is desired :) |
LongYinan (Brooooooklyn)
approved these changes
Aug 14, 2026
LongYinan (Brooooooklyn)
merged commit Aug 14, 2026
32a8b73
into
swc-project:master
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This directly addreses #1071
/esm-registerusesregisterwhich is deprecated. See: https://nodejs.org/api/module.html#moduleregisterspecifier-parenturl-optionsThis PR adds
/esm-register-nextwhich addsregisterHooks.You'll see that I also added
/esm-next. This is because the existing/esmentrypoint is async andregisterHooksis explicitly a synchronous API.I've added it as an explicit separate entrypoint just in case it has knock-on effects that I'm not aware of.