fix(ci): upgrade Node.js to v22 and use pnpm config for npm release - #651
Closed
Tamim Hasan (tamimlabs) wants to merge 5 commits into
Closed
fix(ci): upgrade Node.js to v22 and use pnpm config for npm release#651Tamim Hasan (tamimlabs) wants to merge 5 commits into
Tamim Hasan (tamimlabs) wants to merge 5 commits into
Conversation
|
|
|
Donny/강동윤 (kdy1)
pushed a commit
that referenced
this pull request
Aug 12, 2026
Fixes #650. `npm install -g npm@latest` now resolves npm 12, which requires Node `^22.22.2 || ^24.15.0 || >=26.0.0`. The workflow pins Node 20, so the step fails before `pnpm publish` runs: ``` npm error notsup Required: {"node":"^22.22.2 || ^24.15.0 || >=26.0.0"} npm error notsup Actual: {"npm":"10.8.2","node":"v20.20.2"} ``` Every publish since 2026-07-13 failed this way (runs 296–299), so `swc_core` v73–v76 never reached npm. Node 24 bundles npm 11.17.0, already above the 11.5.1 floor trusted publishing needs, so the step is removed rather than re-pinned — that drops `npm@latest` as a recurring break. Node 20 is also deprecated on GHA runners. Not covered here: the four missed versions (`@swc/plugin-styled-jsx` 13.16.0–13.19.0 and siblings) still need publishing. Re-running the failed runs replays the Node 20 workflow, and the `publish` environment is restricted to `main`, so that needs a maintainer decision. Overlaps with #651, which fixes the same root cause via Node 22; that one keeps the `npm@latest` step and adds `NPM_TOKEN` auth, which would sidestep the OIDC trusted publishing added in #528.
Member
|
Thanks, but closing in favor of #652 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR resolves the CI failure in the Publish npm workflow caused by Node engine incompatibilities and package manager authentication issues.
1. Node.js Engine Mismatch (
EBADENGINE)npm install -g npm@latestwas attempting to installnpm@12.x, which strictly requires Node.js^22.22.2,^24.15.0, or>=26.0.0. The runner was configured with Node.jsv20.x, leading to anEBADENGINEbuild failure.actions/setup-node@v4to usenode-version: 22.2. Authentication Configuration (
ENEEDAUTH)pnpm publishwas failing withENEEDAUTHdue to missing registry token scope resolution when invokingnpm config set.pnpmuses its own configuration hierarchy and does not reliably inheritnpmCLI authorization flags.npm config setwithpnpm config set //registry.npmjs.org/:_authTokento ensurepnpmcorrectly recognizes theNPM_TOKENsecret during workspace publication.Testing
npm@latest.