Feat: update Oauth2_proxy to support the is_admin claim instead of th… - #576
Open
rensvmoorsel wants to merge 1 commit into
Open
rensvmoorsel wants to merge 1 commit into
rensvmoorsel wants to merge 1 commit into
Conversation
…e hardcoded admins
rensvmoorsel
requested review from
KoenDR06 and
stickyPiston
and
a lite review from Copilot
September 15, 2026 19:18
There was a problem hiding this comment.
🟡 Changes recommended
Configure is_admin as a string/array claim or use a dedicated groups claim before applying the filter.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates OAuth2 Proxy admin access to use the is_admin OIDC claim instead of hardcoded email allowlists.
Changes:
- Adds claim-based admin authorization.
- Removes authorized-user file provisioning.
- Removes environment-specific admin email configuration.
- The boolean claim format is incompatible with the configured group filtering.
File summaries
| File | Description |
|---|---|
ansible/roles/oauth2_proxy/templates/admin-config.cfg.j2 |
Configures is_admin-based authorization; the boolean claim may reject all admin sessions. |
ansible/roles/oauth2_proxy/tasks/main.yml |
Removes authorized-user file creation. |
ansible/group_vars/staging/vars.yml |
Removes staging admin emails. |
ansible/group_vars/production/vars.yml |
Removes production admin emails. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+12
to
+13
| oidc_groups_claim = "is_admin" | ||
| allowed_groups = [ "true" ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e hardcoded admins