fix: add sleep after docker stop in main website deployment - #573
Merged
Merged
Conversation
TobiasDeBruijn
approved these changes
Sep 4, 2026
TobiasDeBruijn
left a comment
TobiasDeBruijn
left a comment
Member
There was a problem hiding this comment.
we might want to find a more permanent solution, but ill take it
TobiasDeBruijn
deleted the
fix/timeout-after-docker-stop-main-website
branch
September 4, 2026 11:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main website some times fails to deploy the docker container because it tries to start a docker container with the same name, which might still be in the process of stopping. Adding a
sleep 12should allow for enough time fordocker stopto stop and remove the old container, so that the new container can safely be started reusing the name.