Added data structure for exposing country descriptions#121
Conversation
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
c4e14e6 to
8a9f552
Compare
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
f3782ec to
cb566db
Compare
|
@cweitkamp Thank you for your effort but this API is in my view only about handling holiday calendars. Those calendars are structuring holidays hierarchically without interpreting those hierarchies. They can be (and are mainly, looking at the provided ones) countries. But even the provided calendars contain examples like Holidays_nsye_euronext.xml which contain holidays of the NYSE. Generally should it be possible to have any kind of hierarchical structure of holidays like i.e.
I admit that I have also started thinking only about countries first but since I have seen several different kind of holiday calendar structures. |
|
@svendiedrichsen Thank you for your opinion. You are absolutely right. To take care of the country structure is not the purpose of this API. For the requirements specified in #110 it would be sufficient to expose the resource bundles of country descriptions. Would it be okay for you to change the visibility of the methods jollyday/src/main/java/de/jollyday/util/ResourceUtil.java Lines 162 to 164 in fcc9b8f |
For discussion:
As a side note: May formatter is different than yours. Bear with me if this does not comply with your guidelines.
// EDIT: I just found your code-formatter.xml ...
Closes #110
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de