Skip to content

Fix: Committed .grok/settings.json bypasses workspace trust and controls sandbox security posture #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
superagent-security-dev wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −4
Open

Fix: Committed .grok/settings.json bypasses workspace trust and controls sandbox security posture #340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/utils/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,17 +568,16 @@ export function mergeLspSettings(
}

export function getCurrentSandboxMode(): SandboxMode {
const project = loadProjectSettings();
if (project.sandboxMode) return normalizeSandboxMode(project.sandboxMode);
const user = loadUserSettings();
if (user.sandboxMode) return normalizeSandboxMode(user.sandboxMode);
return "off";
}

export function getCurrentSandboxSettings(): SandboxSettings {
const user = loadUserSettings();
const project = loadProjectSettings();
return mergeSandboxSettings(user.sandbox, project.sandbox);
// Sandbox security posture is user-controlled only; project .grok/settings.json
// is repo-committed and untrusted (see project-hooks exclusion in src/hooks/config.ts).
return user.sandbox ?? {};
}

export function getCurrentLspSettings(): NormalizedLspSettings {
Expand Down
Loading