fix(cli): bypass loopback proxying (CLI-2034) - #6283
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b9e2727182
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@2db54c5672749c359d29edf9a93f4a5a3afa223ePreview package for commit |
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
TL;DR
Keep
supabase starthealth probes to the local Kong gateway off HTTP(S) proxiesrestoring the previous Go CLI behavior for the CLI's canonical loopback addresses.
What regressed?
The native TypeScript port moved these probes from Go's
net/httpclient to Bun'sfetch.Go bypassed proxies for localhost and loopback addresses, while Bun honors
HTTP_PROXYandHTTPS_PROXYunlessNO_PROXYis configured...With a proxy configured, PostgREST and Edge Runtime readiness probes can be sent to the proxy instead of
127.0.0.1, causing a healthy local stack to fail startup and roll back...fixed now by:
Append
localhost,127.0.0.1, and[::1]to Bun's activeNO_PROXYvariable immediately beforestartperforms its local gateway probes.Existing exclusions are preserved, and the late placement keeps the synthetic value out of project dotenv resolution and container environments...
Ref
resolves: #3265 (comment)