Skip to content

Added method self.all for class Worklog #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abataloff wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added method self.all for class Worklog #188

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af9ae07
Added method self.all for class Worklog
abataloff Oct 19, 2016
a1757a9
Using self.new instead client.Worklog.build for init Worklog
abataloff Jul 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/jira/resource/worklog.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,16 @@ class Worklog < JIRA::Base
has_one :author, :class => JIRA::Resource::User
has_one :update_author, :class => JIRA::Resource::User,
:attribute_key => "updateAuthor"
belongs_to :issue
nested_collections true

def self.all(client, options = {})
url = client.options[:rest_base_path] + "/issue/#{options[:issue].key}/worklog"
response = client.get(url)
json = parse_json(response.body)
json['worklogs'].map do |worklog|
client.Worklog.build(worklog)

@SimonMiaou SimonMiaou Jul 21, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using new?

        json['worklogs'].map do |attrs|
          self.new(client, {:attrs => attrs})
        end

This would allow you to put back issue and probably make the tests green again

end
end
end

end
Expand Down