Skip to content

feat(protos)!: remove deprecated IntervalDayToSecond.microseconds field #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nielspardon wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −7
Open

feat(protos)!: remove deprecated IntervalDayToSecond.microseconds field #1116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions proto/substrait/algebra.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1187,20 +1187,19 @@ message Expression {
}

message IntervalDayToSecond {
reserved 3; // formerly the deprecated microseconds field, replaced by precision and subseconds
reserved "microseconds";

int32 days = 1;
int32 seconds = 2;

// Consumers should expect either (miroseconds) to be set or (precision and subseconds) to be set
oneof precision_mode {
int32 microseconds = 3 [deprecated = true]; // use precision and subseconds below, they cover and replace microseconds.
// Sub-second precision, 0 means the value given is in seconds, 3 is milliseconds, 6 microseconds, 9 is nanoseconds, 12 is picoseconds. Should be used with subseconds below.
int32 precision = 4;
}
// Sub-second precision, 0 means the value given is in seconds, 3 is milliseconds, 6 microseconds, 9 is nanoseconds, 12 is picoseconds. Should be used with subseconds below.
int32 precision = 4;

// The sub-second component only, expressed as the number of 1e(-precision)
// units (e.g. with precision 12 this is a number of picoseconds in the
// range [0, 1e12)). Whole seconds belong in the seconds field above, not
// here. Should only be used with precision field, not microseconds.
// here. Should only be used with precision field.
int64 subseconds = 5;
}

Expand Down