Skip to content

refactor(core)!: remove deprecated Join.JoinType.SEMI/ANTI #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nielspardon wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −18
Open

refactor(core)!: remove deprecated Join.JoinType.SEMI/ANTI #1006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions core/src/main/java/io/substrait/relation/Join.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,7 @@ public enum JoinType {
/**
* Right mark join: right rows with an appended boolean column marking whether a match exists.
*/
RIGHT_MARK(JoinRel.JoinType.JOIN_TYPE_RIGHT_MARK),
// deprecated values last to not get them looked up first in fromProto()
/** use {@link #LEFT_SEMI} instead */
@Deprecated
SEMI(JoinRel.JoinType.JOIN_TYPE_LEFT_SEMI),
/** use {@link #LEFT_ANTI} instead */
@Deprecated
ANTI(JoinRel.JoinType.JOIN_TYPE_LEFT_ANTI);
RIGHT_MARK(JoinRel.JoinType.JOIN_TYPE_RIGHT_MARK);

private JoinRel.JoinType proto;

Expand Down Expand Up @@ -135,8 +128,6 @@ private Stream<Type> getRightTypes() {
case OUTER:
case LEFT_SINGLE:
return getRight().getRecordType().fields().stream().map(TypeCreator::asNullable);
case SEMI:
case ANTI:
case LEFT_SEMI:
case LEFT_ANTI:
case LEFT_MARK:
Expand Down
6 changes: 0 additions & 6 deletions isthmus/src/main/java/io/substrait/isthmus/SubstraitRelNodeConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,12 +259,6 @@ private JoinRelType asJoinRelType(Join join) {
if (type == JoinType.OUTER) {
return JoinRelType.FULL;
}
if (type == JoinType.SEMI) {
return JoinRelType.SEMI;
}
if (type == JoinType.ANTI) {
return JoinRelType.ANTI;
}
if (type == JoinType.LEFT_SEMI) {
return JoinRelType.SEMI;
}
Expand Down
2 changes: 0 additions & 2 deletions spark/src/main/scala/io/substrait/spark/logical/ToLogicalPlan.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,6 @@ class ToLogicalPlan(val spark: AnyRef = SparkCompat.instance.getOrCreateSparkSes
case relation.Join.JoinType.LEFT => LeftOuter
case relation.Join.JoinType.RIGHT => RightOuter
case relation.Join.JoinType.OUTER => FullOuter
case relation.Join.JoinType.SEMI => LeftSemi
case relation.Join.JoinType.ANTI => LeftAnti
case relation.Join.JoinType.LEFT_SEMI => LeftSemi
case relation.Join.JoinType.LEFT_ANTI => LeftAnti
case relation.Join.JoinType.UNKNOWN =>
Expand Down
Loading