Add on-device per-message translation#88
Draft
rexbron wants to merge 1 commit into
Draft
Conversation
User-initiated translation for received messages using Apple's Translation framework. The detected source language is checked against the user's current locale and skipped when already readable; otherwise the message is queued and translated on-device. The system download prompt is reached via SwiftUI's `.translationTask` (the only public entry point that triggers it), with a pool of three slots so up to three translations run in parallel. Translated messages get a translate-glyph badge, swap the bubble body to the translated text, and reveal the original via tooltip. The context menu and long-press popover both expose Translate / Show Original. Edit, copy, reply, and quote continue to operate on the original body — translation is presentation-only and not persisted. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User-initiated, on-device translation for received messages using Apple's Translation framework — no server round-trip, no third-party API.
TranslationSessionand swaps the bubble to the translated text..translationTask(the only public entry point that triggers it).NLLanguageRecognizer; messages already in the user's current locale are skipped silently (no badge, no menu item).Implementation notes
RelayKit/Translation/MessageTranslator.swifthandles source detection and the readable-language heuristic. It deliberately does not drive translation directly — the framework only prompts for downloads through.translationTask.TimelineViewModelexposes a FIFO queue (pendingTranslationQueueVersion+claimNextTranslation()+runTranslation(for:translate:)). Atomicity comes from@MainActorisolation.TimelineViewrenders 3 invisibleTranslationSlotsubviews; each owns its ownConfiguration@Stateand.translationTask, so slots are independent.TimelineRowView'sEquatablewas updated to includerow.translationandtranslationsVersion, otherwise the NSTableView cell-recycling path would skip body re-evaluation after a translation completed.Test plan
🤖 Generated with Claude Code