Skip to content

Allow setting root ClientConfig settings #2906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rchl wants to merge 7 commits into
base: main
Choose a base branch
from
+4 −0
Open

Allow setting root ClientConfig settings #2906

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
92ab232
Allow setting root ClientConfig settings
rchl May 16, 2026
4d5645c
remove outdated testts
rchl May 16, 2026
5f598fd
Merge branch 'main' into fix/all_settings
rchl May 17, 2026
cf312d9
Merge branch 'main' into fix/all_settings
rchl May 22, 2026
a01e92e
revert changes
rchl May 22, 2026
6f683ac
add root_settings getter
rchl May 22, 2026
c484380
type
rchl May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugin/core/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,6 +870,10 @@ def __getattr__(self, name: str, /) -> Any:
return self._all_settings[name]
raise AttributeError(name)

@property
def root_settings(self) -> Any:
Copy link
Copy Markdown
Member

@jwortmann jwortmann May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be typed a bit more strictly as dict[str, Any], right?

return self._all_settings

@property
@deprecated('Use initialization_options instead')
def init_options(self) -> DottedDict:
Expand Down
Loading