-
Notifications
You must be signed in to change notification settings - Fork 196
Add support to open URI schemes with server-provided content #2890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+96
−32
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
445eb1c
Add support for server-provided document content
jwortmann 24e6e3f
Fix renamed variable
jwortmann 84cc04d
Use builtin command
jwortmann 0448d05
Merge branch 'main' into textDocumentContent
jwortmann ef6ead6
Use higher level method
jwortmann c839aaf
Merge branch 'main' into textDocumentContent
jwortmann c0d82c1
Merge branch 'main' into textDocumentContent
jwortmann 11074eb
Merge branch 'main' into textDocumentContent
jwortmann 17a755e
Merge branch 'main' into textDocumentContent
jwortmann a6cec4d
Merge branch 'main' into textDocumentContent
jwortmann 0abc25f
Need to set URI explicitly now
jwortmann cb1f1f3
Update view content from main thread on refresh
jwortmann 6d98918
Simplify
jwortmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to microsoft/language-server-protocol#1994 (comment) the client is responsible to determine the language/syntax for the buffer. The only information that we have are the URI and the content, but I see no generic way to determine it just from the URI if it is for example something like
generated-source:aca9a9c1-a993-4ae4-b5c0-1864392b4630.Another comment at microsoft/language-server-protocol#1994 (comment) suggests that the editor extension (in VSCode) sets the language ID for a given URI scheme. So we could add this as a new config key that maps URI schemes to syntax names (
Window.new_filetakes the syntax name as a string). It seems that usingscope:source.xxxalso works, but is somewhat buggy, because the syntax name in the bottom right corner is bugged then (sublimehq/sublime_text#4449). But perhaps we could usesublime.find_syntax_by_scopeAPI for that. So maybe it should be a URI scheme -> scope mapping in the config instead.I still think that it is a mistake in the spec design to do it that way, because the language server should easily know the proper language ID for the document content that itself has generated. So it doesn't make much sense to me why it was designed how it is, but frankly we can't do anything about that.