Skip to content

[WIP] Discrete adjoint multi-zone for python wrapper#2787

Open
EvertBunschoten wants to merge 3 commits intodevelopfrom
feature_multizone_disc_adj_pywrapper
Open

[WIP] Discrete adjoint multi-zone for python wrapper#2787
EvertBunschoten wants to merge 3 commits intodevelopfrom
feature_multizone_disc_adj_pywrapper

Conversation

@EvertBunschoten
Copy link
Copy Markdown
Member

@EvertBunschoten EvertBunschoten commented Apr 15, 2026

Proposed Changes

Enable the multi-zone discrete adjoint driver in the python wrapper.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@joshkellyjak
Copy link
Copy Markdown
Contributor

Nice, do you have a test case for this?

@EvertBunschoten
Copy link
Copy Markdown
Member Author

Nice, do you have a test case for this?

Working on it

using Scalar = su2double;
#else
using Scalar = passivedouble;
#endif
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these no longer protected?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Scalar type needs to be visible to the AdjointProduct and Identity class headers

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do it this way instead 38cddb7

I don't want typedefs in header files, which will then propagate to anything that includes the same header, possibly aliasing or coliding with other stuff, also the helper classes can be hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants