Avoid recomputing residual norms for MG early exit#2786
Open
pcarruscag wants to merge 12 commits intodevelopfrom
Open
Avoid recomputing residual norms for MG early exit#2786pcarruscag wants to merge 12 commits intodevelopfrom
pcarruscag wants to merge 12 commits intodevelopfrom
Conversation
bigfooted
reviewed
Apr 13, 2026
bigfooted
reviewed
Apr 13, 2026
bigfooted
reviewed
Apr 13, 2026
bigfooted
reviewed
Apr 13, 2026
bigfooted
reviewed
Apr 14, 2026
bigfooted
reviewed
Apr 14, 2026
bigfooted
reviewed
Apr 14, 2026
fix inf Co-authored-by: Nijso <nijso@hotmail.com>
bigfooted
reviewed
Apr 14, 2026
bigfooted
reviewed
Apr 14, 2026
Co-authored-by: Nijso <nijso@hotmail.com>
Contributor
|
A couple of testcases have very large differences in residuals, and one case is diverging. I will have to check these in more detail to see if they need different settings and produce reasonable results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the norm should include the MG part of the residual, because it is the sum of the 2 that the solver is trying to converge.